Skip to content

feat(mozcloud): externalSecrets -> secrets in container defs, syntax fixes#218

Merged
emaydeck-mozilla merged 4 commits intomainfrom
change-secret-ref-name-containers
Mar 30, 2026
Merged

feat(mozcloud): externalSecrets -> secrets in container defs, syntax fixes#218
emaydeck-mozilla merged 4 commits intomainfrom
change-secret-ref-name-containers

Conversation

@emaydeck-mozilla
Copy link
Copy Markdown
Contributor

One bigger change and one smaller change:

  • Bigger change: container and initContainer definitions now allow you to specify secrets under secrets instead of externalSecrets.
    • This was already true previously, but has since been renamed and reworded to make things clearer and more accurate.
    • The readme has been updated to clarify what goes where.
    • New test cases were added to the external secrets test to ensure that we can mount secrets created outside this chart.
  • Smaller change: Removed unnecessary parentheses for some default statements. These still render the same way.

@emaydeck-mozilla emaydeck-mozilla self-assigned this Mar 26, 2026
@emaydeck-mozilla emaydeck-mozilla requested a review from a team as a code owner March 26, 2026 22:39
@emaydeck-mozilla emaydeck-mozilla force-pushed the change-secret-ref-name-containers branch from bbf2399 to 8cfba8f Compare March 27, 2026 22:06
@emaydeck-mozilla emaydeck-mozilla force-pushed the change-secret-ref-name-containers branch from 8cfba8f to 6a07897 Compare March 30, 2026 18:29
@emaydeck-mozilla emaydeck-mozilla added the no-release A change that can be merged without bumping versions or performing a release. label Mar 30, 2026
@github-actions github-actions bot added the minor New functionality, backwards compatible. label Mar 30, 2026
@emaydeck-mozilla emaydeck-mozilla removed the minor New functionality, backwards compatible. label Mar 30, 2026
@emaydeck-mozilla emaydeck-mozilla merged commit 9a3cdfd into main Mar 30, 2026
@emaydeck-mozilla emaydeck-mozilla deleted the change-secret-ref-name-containers branch March 30, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release A change that can be merged without bumping versions or performing a release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants